Draft
Conversation
Implemented some new functions: GetDisks, GetDiskletter and GetImageInfoD.
This namespace is used to expose some required functions to the GUIApp.
Taken from previous commits, I have updated and refactored this old project to make it work with the new library.
- Rename the function from ChooseISOImage_Click to ChooseImage_Click. - Remove the oversized try..catch block and only use it on the GetImageInfo function call. - Set the SourceDrive to the root path of the chosen image file.
felgmar
force-pushed
the
reimplement-a-gui-application
branch
from
6c80567 to
220e60f
Compare
Replaces 'AdditionalDriversDrive' with 'AdditionalDrive' in ArgumentParser for consistency. Updates Program.cs to log exception messages instead of rethrowing, providing clearer error output during execution.
Refactored disk and driver parameter names for clarity, improved privilege checks, and streamlined user input validation in InstallerManager. Replaced DiskManager.ListAll with GetDisks to return disk info programmatically. Enhanced ProcessManager with more detailed console output during disk formatting. Separated preparation and installation logic in InstallerManager for better structure and error handling.
Modernized build scripts and .gitignore for robust artifact management. Updated target frameworks and NuGet packages. Refactored API: replaced InstallExtraDrivers with AdditionalDriversDrive, improved argument parsing, and enhanced DISM/driver logic. Expanded XML docs and error handling. Major README rewrite with clearer usage and build instructions. Improved CI workflow and permissions.
Change 'name' to GUIApp.app'
- Bump ConsoleApp to 0.0.8.0 and WindowsInstallerLib to 1.1.5.0 - Rename AdditionalDriversDrive to AdditionalDrive for consistency - Improve exception handling: print errors instead of rethrowing in Program.cs - Add InstallerManager.Prepare to separate disk formatting/validation - Replace DiskManager.ListAll with GetDisks for better disk selection - Streamline interactive prompts and input validation - Simplify firmware type detection logic - Use "bcdboot.exe" for bootloader installation - Enhance disk formatting feedback in ProcessManager - Refactor InstallerManager to throw errors for better propagation - Remove unused methods and improve argument validation for maintainability
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR reimplements the GUI app deleted quite some time ago. Brought back by myself, refactored and updated to make it work with the new library.